Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .windows() producer for negative stride arrays #957

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Conversation

bluss
Copy link
Member

@bluss bluss commented Mar 27, 2021

Avoid using ArrayView::from_shape_ptr (public constructor) because it
does not allow negative stride arrays.

Use the internal constructor ArrayView::new, which is easier.

Fixes #953

Avoid using ArrayView::from_shape_ptr (public constructor) because it
does not allow negative stride arrays.

Use the internal constructor ArrayView::new, which is easier.
@bluss bluss merged commit a77825a into master Mar 27, 2021
@bluss bluss deleted the neg-stride-windows branch March 27, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in windows of a view with negative strides
1 participant